Update/pattern headings #543

troychaplin · 2024-10-10T01:41:32Z

Description

To update patterns to have headings as per the comments in #408

Screenshots

github-actions · 2024-10-10T01:41:45Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: troychaplin <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2024-10-10T01:41:46Z

Preview changes

You can preview these changes by following the link below:

Preview changes for twentytwentyfive

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

carolinan · 2024-10-10T05:16:25Z

patterns/page-link-in-bio-with-tight-margins.php

-				<!-- /wp:paragraph -->
+				<!-- wp:heading {"textAlign":"left","style":{"typography":{"lineHeight":"1.2"}},"fontSize":"x-large"} -->
+				<h2 class="wp-block-heading has-text-align-left has-x-large-font-size" style="line-height:1.2"><?php esc_html_e( 'I&rsquo;m Asahachi Kōno, a Japanese&nbsp;photographer, a member of&nbsp;Los Angeles\'s Japanese Camera Pictorialists of California. Before returning to Japan, I worked as a photo retoucher.', 'twentytwentyfive' ); ?></h2>
+				<!-- /wp:heading -->


I am not sure about this one. It does not feel like a heading above other content?

Agreed, reverted in recent commit

carolinan · 2024-10-10T05:18:44Z

patterns/page-cv-bio.php

-					<p class="has-text-align-left" style="font-size:22rem;letter-spacing:-0.03em"><?php echo esc_html_x( 'Hey,', 'Example heading above the content of the CV/Bio pattern.', 'twentytwentyfive' ); ?></p>
-					<!-- /wp:paragraph -->
-
+					<!-- wp:heading {"textAlign":"left","className":"wp-block-heading","style":{"typography":{"fontSize":"22rem","letterSpacing":"-0.03em","fontStyle":"normal","fontWeight":"300","lineHeight":"1.4"}}} -->


This custom className is not needed. It will show up in the additional CSS field in the editor.

Fix in recent commit

carolinan · 2024-10-10T05:25:04Z

patterns/banner-cover-big-heading.php

-			<!-- wp:paragraph {"align":"left","style":{"typography":{"fontSize":"clamp(1rem, 380px, 24vw)","letterSpacing":"-0.02em","lineHeight":"1","fontWeight":"700"}}} -->
-			<p class="has-text-align-left" style="font-size:clamp(1rem, 380px, 24vw);font-weight:700;letter-spacing:-0.02em;line-height:1"><?php esc_html_e( 'Stories', 'twentytwentyfive' ); ?></p>
-			<!-- /wp:paragraph -->
+			<!-- wp:heading {"align":"left","className":"has-text-align-left","style":{"typography":{"fontSize":"clamp(1rem, 380px, 24vw)","letterSpacing":"-0.02em","lineHeight":"1","fontWeight":"700","fontStyle":"normal"}}} -->


The custom className is not needed. It will show up in the additional CSS field in the editor.

Fix in recent commit

beafialho · 2024-10-10T11:38:32Z

Thank you @troychaplin, rhese are looking good to me. Where these three the only patterns that had these changes?

troychaplin · 2024-10-10T11:41:46Z

Thank you @troychaplin, rhese are looking good to me. Where these three the only patterns that had these changes?

After better review of my notes and comments from @carolinan I believe these may be the only changes required. I made a couple notes here, not sure if either will require changes.

juanfra

Thank you @troychaplin

The aesthetics looks good, how it was. I left a couple of comments.

juanfra · 2024-10-10T13:43:03Z

patterns/page-cv-bio.php

-					<!-- /wp:paragraph -->
-
+					<!-- wp:heading {"textAlign":"left","style":{"typography":{"fontSize":"22rem","letterSpacing":"-0.03em","fontStyle":"normal","fontWeight":"300","lineHeight":"1.4"}}} -->
+					<h2 class="wp-block-heading has-text-align-left" style="font-size:22rem;font-style:normal;font-weight:300;letter-spacing:-0.03em;line-height:1.4"><?php echo esc_html_e( 'Hey,', 'twentytwentyfive' ); ?></h2>


Can we keep the esc_html_x here so that there's context for the translators? Hey, is a text that can cause some confusion.

Changes push in latest commit

juanfra · 2024-10-10T13:43:51Z

patterns/page-cv-bio.php

+					<!-- wp:heading {"textAlign":"left","style":{"typography":{"fontSize":"22rem","letterSpacing":"-0.03em","fontStyle":"normal","fontWeight":"300","lineHeight":"1.4"}}} -->
+					<h2 class="wp-block-heading has-text-align-left" style="font-size:22rem;font-style:normal;font-weight:300;letter-spacing:-0.03em;line-height:1.4"><?php echo esc_html_e( 'Hey,', 'twentytwentyfive' ); ?></h2>
+					<!-- /wp:heading -->
+					 


Can we fix this? It looks like there's an empty space.

Changes push in latest commit

troychaplin added 7 commits October 9, 2024 17:57

update: heading on cover with big heading pattern

238fb9b

update: heading on cv/bio pattern

ba5b90f

update: heading on link in bio with tight margins pattern

c7744f4

update: heading on cv/bio pattern

87f0981

update: heading on cocver with big heading pattern

8762361

update: add translate to heading in cover with big heading pattern

21c41cb

update: heading on link in bio with tight margins pattern

9930d91

update: translation from x to e

6ced807

carolinan reviewed Oct 10, 2024

View reviewed changes

troychaplin added 4 commits October 10, 2024 07:32

fix: removed className from block markup

fcb63c3

fix: removed className from block markup

f1bc582

change: revert back to previous version of pattern

056d9b4

Merge branch 'trunk' into update/pattern-headings

473586e

juanfra reviewed Oct 10, 2024

View reviewed changes

juanfra added the [Type] Enhancement A suggestion for improvement. label Oct 10, 2024

juanfra assigned troychaplin Oct 10, 2024

update: use _x and added context to cv bio pattern, removed empty line

10c991b

carolinan merged commit 7b2f3d4 into WordPress:trunk Oct 11, 2024
5 of 7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update/pattern headings #543

Update/pattern headings #543

troychaplin commented Oct 10, 2024

github-actions bot commented Oct 10, 2024 •

edited

Loading

github-actions bot commented Oct 10, 2024 •

edited

Loading

carolinan Oct 10, 2024

troychaplin Oct 10, 2024 •

edited

Loading

carolinan Oct 10, 2024

troychaplin Oct 10, 2024

carolinan Oct 10, 2024

troychaplin Oct 10, 2024

beafialho commented Oct 10, 2024

troychaplin commented Oct 10, 2024 •

edited

Loading

juanfra left a comment

juanfra Oct 10, 2024

troychaplin Oct 10, 2024

juanfra Oct 10, 2024

troychaplin Oct 10, 2024

Update/pattern headings #543

Update/pattern headings #543

Conversation

troychaplin commented Oct 10, 2024

github-actions bot commented Oct 10, 2024 • edited Loading

github-actions bot commented Oct 10, 2024 • edited Loading

Preview changes

Choose a reason for hiding this comment

troychaplin Oct 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

beafialho commented Oct 10, 2024

troychaplin commented Oct 10, 2024 • edited Loading

juanfra left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Oct 10, 2024 •

edited

Loading

github-actions bot commented Oct 10, 2024 •

edited

Loading

troychaplin Oct 10, 2024 •

edited

Loading

troychaplin commented Oct 10, 2024 •

edited

Loading